refactor: remove duplicated iptables subnet forward rules #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
oilbeater
force-pushed
the
perf/iptables
branch
from
3169bff to
f52b8ac
Compare
Pull Request Test Coverage Report for Build 12430023583Details
💛 - Coveralls |
The ipset based iptables rules have already did the work. Signed-off-by: oilbeater <[email protected]>
oilbeater
force-pushed
the
perf/iptables
branch
from
f52b8ac to
97d92dc
Compare
|
The subnet metrics relies on these rules, we should consider a batch way to update these rules. |
changluyi
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ipset based iptables rules have already did the work.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #4859